MFBot 4.4.2 Crash With Arena Delay

[TerryS]

(Sorry, English is my only language beyond 2 years of Spanish over twenty years ago.)

Modified MFBot through the Global Settings. It was confusing because I'd changed several different things so determining what went wrong and caused MFBot to crash was difficult. Eventually, through going through the INI file determined what can regularly cause MFBot to crash.

In [Common]
ARENA.MAX_WAIT=60

will crash the bot. I do have 12 users in the INI file, but it crashed countless times with me manipulating an entry at a time. Did have:

ARENA.MAX_WAIT=60
ARENA.MIN_CHANCE=55
ARENA.MIN_WAIT=50

This would crash both the GUI and Konsole every time. Seemed to be at a random character (i.e. the character changed) but the bot would give errors.

(From General.log)
20160522 18:59:41 Error Core Value of '25' is not valid for 'Value'. 'Value' should be between 'Minimum' and 'Maximum'.
Parameter name: Value
Message: Value of '25' is not valid for 'Value'. 'Value' should be between 'Minimum' and 'Maximum'.
Parameter name: Value
HResult: -2146233086
Source: System.Windows.Forms
StackTrace: at System.Windows.Forms.NumericUpDown.set_Value(Decimal value)
at de.mfbot.MFBot_NG.Gui.FrmBotSettings..ctor(Boolean debug)
at (Boolean )
at A.
.(Boolean )
at de.mfbot.MFBot_NG.Gui.FrmMain.
(Object , EventArgs )
at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
at System.Windows.Forms.ToolStrip.WndProc(Message& m)
at System.Windows.Forms.MenuStrip.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
TargetSite: Void set_Value(System.Decimal)

Individual characters would have:

20160522 18:22:54 Error Core Object reference not set to an instance of an object.
Message: Object reference not set to an instance of an object.
HResult: -2147467261
Source: Basisbibliothek
StackTrace: at de.mfbot.MFBot_NG.Basisbibliothek.Account.()
at de.mfbot.MFBot_NG.Basisbibliothek.Account.()
TargetSite: Boolean ()


Konsole output was:

Unhandled Exception: System.ArgumentOutOfRangeException: 'minValue' cannot be gr
eater than maxValue.
Parameter name: minValue
at System.Random.Next(Int32 minValue, Int32 maxValue)
at de.mfbot.MFBot_NG.Basisbibliothek.Account.()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionCo
ntext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, C
ontextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, C
ontextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()

Unhandled Exception: System.ArgumentOutOfRangeException: 'minValue' cannot be gr
eater than maxValue.
Parameter name: minValue
at System.Random.Next(Int32 minValue, Int32 maxValue)
at de.mfbot.MFBot_NG.Basisbibliothek.Account.()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionCo
ntext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, C
ontextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, C
ontextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
5/22/2016 6:48:50 PM Info RequestResponse NAME@SERVER Account has been
logged in.



Finally, one crash I caught the ARENA.MAX_WAIT reverted to 0. Changed to:

ARENA.MAX_WAIT=55
ARENA.MIN_WAIT=45

Global Settings won't come up, but the BOT is fully functional, at least it appears to be.

Terry

P.S. Is there some entry that can be done to increase debugging? Seeing what actions are attempted before the crash would have narrowed the problem down much simpler than changing a couple of entries at a time.

[Baaam]

Hey,

I just marked the important things in red. You might have manually set a timer in the ini file to some invalid value. We defined min and max values in the bot and this crashes occur when you exceed them by manual editing.
Unfortunately I can not see the problem regarding your acc.ini. Maybe you can send me the whole ini (without password!) via primate message here.

[TerryS]

Message sent off with INI file (attached as JPG because the only valid "Custom Filetype" I could find was JPG. TXT, Ini, WasINI and such were not valid.

One note based upon your comment, the initial modifications were via the GUI. Only after it crashed did I start modifying directly in the INI. (Of course, at that point the GUI wasn't available to do my modifications.)

Actually, after finding the problem, turning off AUTOLOGON probably would have allowed me to use the GUI.

Thanks for your help,

Terry

[TerryS]

Actually, thinking about it, I believe I'd initially set the arena to 60-75 minute range. Considering I caught it when the range was 50-60 having the 60 reset to 0, that's likely what caused the max to be greater than the minimum.

Terry

[Baaam]

# fixed in the next patch