Support for S&F Account login

Alle Arten von Feature-Wünschen können hier gestellt werden.
Benutzeravatar
Robin
Administrator
Beiträge: 1723
Registriert: So 30. Jun 2013, 18:12
Wohnort: Rheinland-Pfalz
Hat sich bedankt: 303 Mal
Danksagung erhalten: 354 Mal

Re: Support for S&F Account login

Beitrag von Robin »

Hi everyone, to clarify:

TL;DR: You can still use/add legacy character logins (with username/password) after the bot update, the new SSO option is.. well, optional.

What we've got so far is that you get a new button on the "New account" window that allows you to log in to your SF-Account and get a character list.
You can then select which characters you want to use in the bot (including accounts that are already added via user/password) and the bot will take care of the rest for you.

The window that allows you to use the SF-Account is a completely new one and might be extended in the future to allow managing your current SSO accounts (e.g. change password) or to use different SSO providers like Facebook.
Folgende Benutzer bedankten sich beim Autor Robin für den Beitrag (Insgesamt 4):
Marcin97 (Fr 5. Mai 2023, 22:24) • Uwaga (Fr 5. Mai 2023, 23:44) • Crossland (Sa 6. Mai 2023, 09:25) • Aldimanni (Sa 6. Mai 2023, 19:23)
MFBot-VersionCode-Zeilen*In Dateien*Letzte Version
MFBot 1.5.x64851Juli 2013
MFBot 2.x1436316März 2014
MFBot 3.x2209536März 2015
MFBot 4.x55242241Juli 2018
MFBot 5.x66000440Tbc
*Ohne automatisch generierten Designer-Code
FritzvonBenny
Beiträge: 14
Registriert: Mi 27. Jul 2022, 22:27
Hat sich bedankt: 3 Mal
Danksagung erhalten: 3 Mal

Re: Support for S&F Account login

Beitrag von FritzvonBenny »

Please add the option to log in to multiple S&F accounts at the same time
NameCZ
Beiträge: 1
Registriert: Fr 5. Mai 2023, 22:53
Hat sich bedankt: 0
Danksagung erhalten: 0

Re: Support for S&F Account login

Beitrag von NameCZ »

Hello, when will this feature be added to CRAWLERNG?
Benutzeravatar
Robin
Administrator
Beiträge: 1723
Registriert: So 30. Jun 2013, 18:12
Wohnort: Rheinland-Pfalz
Hat sich bedankt: 303 Mal
Danksagung erhalten: 354 Mal

Re: Support for S&F Account login

Beitrag von Robin »

Update: Approx. 2000 lines of code later, the basics are now implemented and the first account has been logged in via the new UI option :geek:
I'll begin to optimize things tomorrow so that it's actually usable without having a debugger attached (a process I like to call "taking off the training wheels") - I will report back as soon as I've something to report.

In regard to the question for adjusting the Crawler: No ETA at the moment, as always we focus on the bot first and will update the Crawler if we've got time left and the original author of the Crawler doesn't.

Also: Thank you all for your positive feedback, we're glad to hear you like our work - but in the interest of keeping this thread readable for anyone involved, please consider just pressing the 'thumbs up' button on a post and think twice if a question is really matching this topic! :slightly_smiling_face:
Folgende Benutzer bedankten sich beim Autor Robin für den Beitrag (Insgesamt 18):
neuhier (Sa 6. Mai 2023, 02:22) • Rum (Sa 6. Mai 2023, 07:49) • lagertha (Sa 6. Mai 2023, 08:07) • smoodo (Sa 6. Mai 2023, 08:16) • desto_gsxr (Sa 6. Mai 2023, 08:43) • Bossi (Sa 6. Mai 2023, 09:20) • Lygari (Sa 6. Mai 2023, 09:24) • Crossland (Sa 6. Mai 2023, 09:26) • potato (Sa 6. Mai 2023, 09:51) • Gustav (Sa 6. Mai 2023, 10:13) und 8 weitere Benutzer
MFBot-VersionCode-Zeilen*In Dateien*Letzte Version
MFBot 1.5.x64851Juli 2013
MFBot 2.x1436316März 2014
MFBot 3.x2209536März 2015
MFBot 4.x55242241Juli 2018
MFBot 5.x66000440Tbc
*Ohne automatisch generierten Designer-Code
Benutzeravatar
Robin
Administrator
Beiträge: 1723
Registriert: So 30. Jun 2013, 18:12
Wohnort: Rheinland-Pfalz
Hat sich bedankt: 303 Mal
Danksagung erhalten: 354 Mal

Re: Support for S&F Account login

Beitrag von Robin »

Hi everyone,

a lot of changes and adjustments later, we'd like to give you a Nightly version to test the current draft.
You can download a subset of the usual versions here: https://download.mfbot.de/?dir=na297b582

There are two main UI changes:
  • A new button in "Add new account" (at the bottom) can be used to import/link new characters and ones that aren't on the bot, yet.
  • If you try to login an account that is linked to an S&F account not yet known to the bot (or where the character is not imported from that account yet), the bot will ask you to connect the character over that account via the same window
Please note that this version contains some minor, unrelated additional changes that come with the next version, including ignoring events the bot doesn't know about and logging it instead of just guessing what event it might be.

We're interested in any feedback you can give regarding the new S&F account handling, especially about the stability and clarity on how you can use it in the bot (e.g. "is it self-explanatory enough?").
In the meantime, we're having a look into whether we can squeeze handling multiple SF accounts into the next Release.

Thanks in advance!
Robin
Zuletzt geändert von Robin am So 7. Mai 2023, 01:21, insgesamt 1-mal geändert.
Grund: Adjusted link for newest version
Folgende Benutzer bedankten sich beim Autor Robin für den Beitrag (Insgesamt 6):
Uwaga (Sa 6. Mai 2023, 19:17) • Aldimanni (Sa 6. Mai 2023, 19:22) • Howeverr (Sa 6. Mai 2023, 21:08) • Lygari (So 7. Mai 2023, 05:44) • smoodo (So 7. Mai 2023, 07:11) • Marcin97 (So 7. Mai 2023, 12:43)
MFBot-VersionCode-Zeilen*In Dateien*Letzte Version
MFBot 1.5.x64851Juli 2013
MFBot 2.x1436316März 2014
MFBot 3.x2209536März 2015
MFBot 4.x55242241Juli 2018
MFBot 5.x66000440Tbc
*Ohne automatisch generierten Designer-Code
Uwaga
Beiträge: 7
Registriert: Mi 3. Mai 2023, 12:51
Hat sich bedankt: 7 Mal
Danksagung erhalten: 5 Mal

Re: Support for S&F Account login

Beitrag von Uwaga »

Already downloaded the new version and set everything up - the configuration is absolutely clear and the bot itself works like a charm :) Thanks a lot for providing the updated version really quickly!
Folgende Benutzer bedankten sich beim Autor Uwaga für den Beitrag (Insgesamt 3):
Robin (Sa 6. Mai 2023, 19:43) • Howeverr (Sa 6. Mai 2023, 21:08) • Floki (Sa 6. Mai 2023, 22:24)
Uwaga
Beiträge: 7
Registriert: Mi 3. Mai 2023, 12:51
Hat sich bedankt: 7 Mal
Danksagung erhalten: 5 Mal

Re: Support for S&F Account login

Beitrag von Uwaga »

I've noticed one strange detail - when I look to the Account Log of a character linked to S&F Account, there are two warnings after logging in - "Unknown Sub-Event value: 1153":

Bild

Nevertheless, everything is running perfectly fine.
Folgende Benutzer bedankten sich beim Autor Uwaga für den Beitrag:
Floki (Sa 6. Mai 2023, 22:24)
Benutzeravatar
Robin
Administrator
Beiträge: 1723
Registriert: So 30. Jun 2013, 18:12
Wohnort: Rheinland-Pfalz
Hat sich bedankt: 303 Mal
Danksagung erhalten: 354 Mal

Re: Support for S&F Account login

Beitrag von Robin »

Oh, yeah, maybe I should have mentioned that the Nightly does have other minor changes that were still laying around on the main development branch before this mess started. :D
We've primarily been working on .NET 6 migration over the past two months, but one of the few changes in the .NET Framework version line is that the bot doesn't try to just assume events it doesn't know (which it can't).

Again for anyone reading just the last post: There are nightly versions available, see viewtopic.php?p=17758#p17758
MFBot-VersionCode-Zeilen*In Dateien*Letzte Version
MFBot 1.5.x64851Juli 2013
MFBot 2.x1436316März 2014
MFBot 3.x2209536März 2015
MFBot 4.x55242241Juli 2018
MFBot 5.x66000440Tbc
*Ohne automatisch generierten Designer-Code
Creaton
Beiträge: 26
Registriert: Mi 3. Mai 2023, 18:27
Hat sich bedankt: 8 Mal
Danksagung erhalten: 7 Mal

Re: Support for S&F Account login

Beitrag von Creaton »

Robin hat geschrieben: Sa 6. Mai 2023, 20:07 Oh, yeah, maybe I should have mentioned that the Nightly does have other minor changes that were still laying around on the main development branch before this mess started. :D
We've primarily been working on .NET 6 migration over the past two months, but one of the few changes in the .NET Framework version line is that the bot doesn't try to just assume events it doesn't know (which it can't).

Again for anyone reading just the last post: There are nightly versions available, see viewtopic.php?p=17758#p17758

What could be wrong if I only have a s2 eu server? S1 and S3 won't add it.What could be wrong? Thx =)
I can see all three characters in my SF account, but it only lets me add 1 account.Unfortunately, the other two are not good.
Gustav
Beiträge: 3
Registriert: So 9. Apr 2023, 16:06
Hat sich bedankt: 1 Mal
Danksagung erhalten: 1 Mal

Re: Support for S&F Account login

Beitrag von Gustav »

I was able to import my EU2 Account, but I get errors trying to import my EU3 Account

I get this error when my EU2 Account logs in but it still works normally:
XXXXXX@S2.SFGAME.EU Unknown Sub-Event value: 1153 Warnung Server Kommunikation

When I try to import my EU3 Account I get this error:
XXXXXX@S3.SFGAME.EU Logging in... Information Basis
XXXXXX@S3.SFGAME.EU Something went wrong on sending a de.mfbot.MFBot_NG.Basisbibliothek.SFAccountCharLoginCommand! Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei System.Collections.Generic.Dictionary`2.get_Item(TKey key) Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei (Object , String ) Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei A.TZW.G(Object G, String W) Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei de.mfbot.MFBot_NG.Basisbibliothek.LoginResponse.G() in File103:Zeile 58. Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei de.mfbot.MFBot_NG.Basisbibliothek.LoginResponse.Build() in File103:Zeile 53. Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei de.mfbot.MFBot_NG.Basisbibliothek.BaseResponse.G(String G, Command W, Account Z) in File110:Zeile 170. Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei de.mfbot.MFBot_NG.Basisbibliothek.Server.D(Account G, Command W, DateTime Z, String D) in File193:Zeile 800. Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei de.mfbot.MFBot_NG.Basisbibliothek.Server.D(Account G, Command W) in File193:Zeile 771. Fehler Server Kommunikation
XXXXXX@S3.SFGAME.EU bei de.mfbot.MFBot_NG.Basisbibliothek.Server.send(Account acc, Command cmd) in File193:Zeile 601. Fehler Server Kommunikation
General Der angegebene Schlüssel war nicht im Wörterbuch angegeben. Fehler Basis
Gesperrt

Wer ist online?

Mitglieder in diesem Forum: 0 Mitglieder und 21 Gäste